[GitHub] [kafka] kamalcph commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-09 Thread via GitHub
kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1288729452 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-02 Thread via GitHub
kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1281723208 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-02 Thread via GitHub
kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1281701381 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-01 Thread via GitHub
kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1280887247 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-08-01 Thread via GitHub
kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1280887247 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-07-31 Thread via GitHub
kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1280095629 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -102,49 +102,14 @@ public String topicWarningMessage(String topicName) {

[GitHub] [kafka] kamalcph commented on a diff in pull request #14114: KAFKA-12969: Add broker level config synonyms for topic level tiered storage configs

2023-07-31 Thread via GitHub
kamalcph commented on code in PR #14114: URL: https://github.com/apache/kafka/pull/14114#discussion_r1278982175 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -424,6 +387,18 @@ public int initFileSize() { return 0; } +