[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304596807 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -21,8 +21,8 @@ import kafka.utils.TestUtils import org.apache.kafka.common.security.JaasUtils

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304553332 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -870,12 +870,17 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304548979 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -301,6 +300,70 @@ class RemoteTopicCrudTest extends IntegrationTestHarness { //

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1301852957 ## core/src/test/scala/unit/kafka/server/TieredStorageSystemWideConfigTest.scala: ## @@ -0,0 +1,100 @@ +package unit.kafka.server + +import

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1301834895 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,27 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300319555 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300316787 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300091311 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1296140643 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,15 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1296143313 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -154,6 +155,96 @@ class KafkaServerTest extends QuorumTestHarness { server.shutdown() }

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1288449342 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1288298071 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1287319821 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC

[GitHub] [kafka] kamalcph commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

kamalcph commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1287319821 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC