[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602040784 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602041263 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602041366 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602041672 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602046050 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602046133 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602048606 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602049062 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602049230 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602049695 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-25 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602052393 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602052452 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602055217 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602055217 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602055675 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602056245 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -213,32 +208,38 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason { }

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602056301 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -213,32 +208,38 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason { }

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602056487 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1794,20 +1269,21 @@ class Log(@volatile private var _dir: File, ret.toSeq.sortBy(-_)

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602062784 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1816,8 +1292,12 @@ class Log(@volatile private var _dir: File, */ private def deleteOl

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602062784 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1816,8 +1292,12 @@ class Log(@volatile private var _dir: File, */ private def deleteOl

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602052452 ## File path: core/src/main/scala/kafka/log/LocalLog.scala ## @@ -0,0 +1,1561 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602071574 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -836,178 +581,15 @@ class Log(@volatile private var _dir: File, updateHighWatermark(off

[GitHub] [kafka] kowshik commented on a change in pull request #10280: KIP-405: Log layer refactor

2021-03-26 Thread GitBox
kowshik commented on a change in pull request #10280: URL: https://github.com/apache/kafka/pull/10280#discussion_r602062784 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1816,8 +1292,12 @@ class Log(@volatile private var _dir: File, */ private def deleteOl