[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r638520142 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1217,10 +1213,8 @@ class Log(@volatile private var _dir: File, fetchDataInfo = seg

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r638520142 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1217,10 +1213,8 @@ class Log(@volatile private var _dir: File, fetchDataInfo = seg

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r638519831 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -210,11 +209,23 @@ class LogSegments(topicPartition: TopicPartition) { * @return t

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631591402 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1219,10 +1216,10 @@ class Log(@volatile private var _dir: File, fetchDataInfo = se

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631584810 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1204,13 +1202,12 @@ class Log(@volatile private var _dir: File, // Do the read on th

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631591402 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1219,10 +1216,10 @@ class Log(@volatile private var _dir: File, fetchDataInfo = se

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631584810 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1204,13 +1202,12 @@ class Log(@volatile private var _dir: File, // Do the read on th

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631581404 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -185,7 +184,7 @@ class LogSegments(topicPartition: TopicPartition) { * if

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631501285 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -17,7 +17,6 @@ package kafka.log import java.io.File -import java.lang.{Long => JL

[GitHub] [kafka] kowshik commented on a change in pull request #10684: MINOR: Improve Log layer segment iteration logic and few other areas

kowshik commented on a change in pull request #10684: URL: https://github.com/apache/kafka/pull/10684#discussion_r631501034 ## File path: core/src/main/scala/kafka/log/LogSegments.scala ## @@ -210,11 +209,23 @@ class LogSegments(topicPartition: TopicPartition) { * @return t