[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485248486 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -439,6 +442,185 @@ public void te

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485235880 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java ## @@ -439,6 +442,185 @@ public void te

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r485053442 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483839060 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483752603 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483718480 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +191,113 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483715845 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -228,13 +345,8 @@ private void putAnd

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483715336 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483695703 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483695703 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483685325 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483685325 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483309087 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483681956 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483309087 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,125 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r483308090 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -161,29 +180,31 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482324434 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +213,127 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482084851 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -311,13 +322,8 @@ private void putAnd

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482079220 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +191,113 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r482078343 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -254,35 +257,43 @@ private void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r481391993 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +191,113 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r481378201 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -192,29 +191,113 @@ public void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r481375834 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -164,11 +161,13 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r480194412 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,386 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r479411830 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478744162 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478743528 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478490860 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -232,40 +239,54 @@ private void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478489438 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -232,40 +239,54 @@ private void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478462394 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -232,40 +239,54 @@ private void proce

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478459405 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -189,8 +195,8 @@ public void processI

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478454716 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,380 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478445137 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478442739 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -174,12 +181,11 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478437596 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,380 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r478435832 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -160,11 +160,18 @@ public void proces

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r477380346 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -148,7 +153,7 @@ public void processI

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476546410 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -210,6 +216,66 @@ public void process

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476531518 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -148,7 +153,7 @@ public void processI

[GitHub] [kafka] lct45 commented on a change in pull request #9157: Update for KIP-450 to handle early records

lct45 commented on a change in pull request #9157: URL: https://github.com/apache/kafka/pull/9157#discussion_r476531745 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -211,6 +217,67 @@ public void process