[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-02 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r534256605 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533586582 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java ## @@ -619,8 +647,7 @@ public void

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533585639 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImplTest.java ## @@ -629,16 +657,18 @@ private void

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-12-01 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r533570535 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-11-20 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r527724338 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java ## @@ -377,7 +378,7 @@ private void

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-11-19 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r527117685 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -221,6 +221,9 @@ State setState(final State

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-11-18 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r526355838 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -1070,6 +1070,10 @@ private Thread shutdownHelper(final boolean error) {

[GitHub] [kafka] lct45 commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-11-18 Thread GitBox
lct45 commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r526331025 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/MetricsIntegrationTest.java ## @@ -377,7 +378,7 @@ private void