mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1414149629
Sorry I have just been busy with other things, will look into it next week
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1263294566
@cadonna
> https://github.com/apache/kafka/pull/12524/files#r984332259
This one is resolved now, I think I somehow missed that, apologies
>
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1263241592
@cadonna Apologies, I must have missed the replies to the comments, will
look at them today. Note that
https://github.com/apache/kafka/pull/12524#discussion_r975464527 is still
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1252484624
@cadonna I have addressed the comments which I could. I just noticed that I
have gone back and forth between removing and adding the same
stubs/verifications in various without
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1252139067
@cadonna Okay so I have just pushed and rebased the PR with these changes
* As you have rightly pointed out there were a lot of things being
stubbed/tested which made no sense
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1243928456
Thanks for the comments, I am still get my head around the tests and what
precisely is being tested.
I forgot to mention earlier that `StreamTaskTest` needs more work (doing
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1243525214
@cadonna I have just rebased the PR with the latest streams changes that got
merged into. trunk. I also did some more improvements for `StreamThreadTest`
with the usage of
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1219138597
PR has been rebased and pushed which fixes the problem described earlier,
i.e. usage of `when(storeMetadata.offset()).thenReturn(null);`
--
This is an automated message from the
mdedetrich commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1218227510
@C0urante Thanks for finding the root cause, will definitely keep this as a
mental note when doing other migrations. I'll update the PR later tonight
--
This is an automated message
