[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r943688586 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() { }

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942490893 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() { }

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942316745 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() { }

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942300712 ## server-common/src/main/java/org/apache/kafka/server/metrics/KafkaYammerMetrics.java: ## @@ -53,16 +72,21 @@ public static MetricsRegistry defaultRegistry() { }

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r942291817 ## clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java: ## @@ -98,6 +102,10 @@ public class CommonClientConfigs { public static final String

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r893743558 ## clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java: ## @@ -367,9 +367,11 @@ private void warnIfPartitionerDeprecated() { List

[GitHub] [kafka] mimaison commented on a diff in pull request #12046: KAFKA-10360: Allow disabling JMX Reporter (KIP-830)

mimaison commented on code in PR #12046: URL: https://github.com/apache/kafka/pull/12046#discussion_r855922918 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -331,7 +331,7 @@ public class KafkaAdminClient extends AdminClient { /**