subject:"\[GitHub\] \[kafka\] mimaison commented on a diff in pull request #12804\: \[Minior\] \[Test\] KAFKA\-14344 \: Build EmbeddedKafkaCluster with common configs used for all clients"

[GitHub] [kafka] mimaison commented on a diff in pull request #12804: [Minior] [Test] KAFKA-14344 : Build EmbeddedKafkaCluster with common configs used for all clients

2022-11-03 Thread GitBox

mimaison commented on code in PR #12804: URL: https://github.com/apache/kafka/pull/12804#discussion_r1012744812 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java: ## @@ -106,12 +106,20 @@ public class EmbeddedKafkaCluster { pr

[GitHub] [kafka] mimaison commented on a diff in pull request #12804: [Minior] [Test] KAFKA-14344 : Build EmbeddedKafkaCluster with common configs used for all clients

2022-11-02 Thread GitBox

mimaison commented on code in PR #12804: URL: https://github.com/apache/kafka/pull/12804#discussion_r1012093538 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -640,11 +645,7 @@ protected static void wa