[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

2023-01-04 Thread GitBox
mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1061951302 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedDeserializer.java: ## @@ -24,8 +24,6 @@ public class ChangedDeserializer implements Deserial

[GitHub] [kafka] mjsax commented on a diff in pull request #10747: KAFKA-12446: Define KGroupedTable#aggregate subtractor + adder order of execution

2022-12-28 Thread GitBox
mjsax commented on code in PR #10747: URL: https://github.com/apache/kafka/pull/10747#discussion_r1058656046 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/ChangedSerializer.java: ## @@ -45,34 +45,30 @@ public void setIfUnset(final Serializer defaultKeySeri