[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r898411852 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedSessionStore.java: ## @@ -61,6 +65,18 @@ public QueryResult query(final Query query,

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r898406030 ## streams/src/main/java/org/apache/kafka/streams/state/SessionStore.java: ## @@ -39,6 +39,13 @@ */ public interface SessionStore extends StateStore,

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r898340071 ## streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java: ## @@ -202,25 +205,43 @@ public void remove(final Windowed sessionKey) {

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r898339592 ## streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java: ## @@ -202,25 +205,43 @@ public void remove(final Windowed sessionKey) {

[GitHub] [kafka] mjsax commented on a diff in pull request #12204: [9/N WIP][Emit final] Emit final for session window aggregations

mjsax commented on code in PR #12204: URL: https://github.com/apache/kafka/pull/12204#discussion_r887381498 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregate.java: ## @@ -83,50 +94,64 @@ private class