[GitHub] [kafka] mjsax commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

mjsax commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878687476 Correct, sliding-windows were added later and never had a default grace. Also, we deprecated `until() / maintainMs()` before and because sliding-windows do not inherit from `Windo

[GitHub] [kafka] mjsax commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

mjsax commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-878690334 > Otherwise, Streams app that run with 2.8 and before might not be compatible with Streams 3.0 because the retention time of the changelog topics created with older Streams apps w

[GitHub] [kafka] mjsax commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

mjsax commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-879596929 > There could be data loss, because locally the windowed state store would store records for a longer period of time than in the changelog topic. If a Kafka Streams client is rest

[GitHub] [kafka] mjsax commented on pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

mjsax commented on pull request #10953: URL: https://github.com/apache/kafka/pull/10953#issuecomment-880159699 > but when users upgrade the Streams apps to 3.0 we guarantee retention time T+X I don't agree to this statement. It's a bug in the implementation (that this PR fixes) that