[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875105840 ## metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java: ## @@ -253,6 +263,14 @@ public void replay(RemoveTopicRecord record) { public void

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875213585 ## metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java: ## @@ -17,32 +17,94 @@ package org.apache.kafka.controller; +import

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875200677 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875195765 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -231,6 +252,10 @@ object StorageTool extends Logging { val metaPropertiesPath = Paths.get(directory,

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875105840 ## metadata/src/main/java/org/apache/kafka/image/MetadataDelta.java: ## @@ -253,6 +263,14 @@ public void replay(RemoveTopicRecord record) { public void

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r875087231 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -233,6 +250,19 @@ public String version() { return ibpVersion; }

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r874905164 ## clients/src/main/java/org/apache/kafka/clients/NodeApiVersions.java: ## @@ -91,19 +95,11 @@ public static NodeApiVersions create(short apiKey, short minVersion,

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r872596541 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -53,7 +55,7 @@ public class ClusterConfig { ClusterConfig(Type type, int brokers, int controllers,

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r872493845 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -927,6 +984,29 @@ private void appendRaftEvent(String name, Runnable runnable) {

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r872423670 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r872417278 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871495442 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -93,84 +129,187 @@ boolean featureExists(String featureName) { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871494219 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -927,6 +981,31 @@ private void appendRaftEvent(String name, Runnable runnable) {

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871491412 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -93,84 +129,187 @@ boolean featureExists(String featureName) { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871404277 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -93,84 +129,187 @@ boolean featureExists(String featureName) { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871392227 ## metadata/src/main/java/org/apache/kafka/controller/BootstrapMetadata.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871388241 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -108,7 +108,8 @@ class KafkaRaftManager[T]( time: Time, metrics: Metrics, threadNamePrefixOpt:

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r871388241 ## core/src/main/scala/kafka/raft/RaftManager.scala: ## @@ -108,7 +108,8 @@ class KafkaRaftManager[T]( time: Time, metrics: Metrics, threadNamePrefixOpt:

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r870467175 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -70,13 +47,17 @@ object StorageTool extends Logging { case "format" => val directories =

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r870466924 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -273,6 +301,40 @@ public static MetadataVersion latest() { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r870466324 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -273,6 +301,40 @@ public static MetadataVersion latest() { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r870454341 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -273,6 +301,40 @@ public static MetadataVersion latest() { return

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869631802 ## metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java: ## @@ -55,25 +60,37 @@ public class FeatureControlManager { */ private final

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869621801 ## core/src/main/scala/kafka/server/ControllerServer.scala: ## @@ -63,6 +64,8 @@ class ControllerServer( val threadNamePrefix: Option[String], val

[GitHub] [kafka] mumrah commented on a diff in pull request #12050: KAFKA-13830 MetadataVersion integration for KRaft controller

mumrah commented on code in PR #12050: URL: https://github.com/apache/kafka/pull/12050#discussion_r869326805 ## core/src/main/scala/kafka/server/KafkaRaftServer.scala: ## @@ -102,6 +106,8 @@ class KafkaRaftServer( threadNamePrefix, controllerQuorumVotersFuture,