[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 [WIP] Move ReassignPartitionsCommand to java

2023-08-01 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1661218798 @ijuma @tombentley @mimaison I rewrite `ReassignPartitionsCommand` and all tests belong to it. All tests regarding `ReassignPartitionsCommand.java` pass. The only link to

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 [WIP] Move ReassignPartitionsCommand to java

2023-07-31 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1658638517 Hello @mimaison > If you can think of ways to split it in at least 2 PRs that would be preferable My plan is the following: 1. PR to rewrite AdminUtils -

[GitHub] [kafka] nizhikov commented on pull request #13247: KAFKA-14595 [WIP] Move ReassignPartitionsCommand to java

2023-07-25 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1649759485 @mimaison There are few classes that used elsewhere in code and in `ReassignPartitionsCommand`. Specifically: * `BrokerMetadata` simple case class. * `AdminUtils` partition