[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127264709 ## core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127257845 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -16,90 +16,77 @@ */ package org.apache.kafka.clients.co

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127256908 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -226,11 +246,20 @@ public void commitAsync(OffsetCommitCallbac

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127253922 ## core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127253699 ## core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127252457 ## core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127251663 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -16,90 +16,77 @@ */ package org.apache.kafka.clients.co

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127250227 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -16,90 +16,77 @@ */ package org.apache.kafka.clients.co

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127046532 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -83,12 +92,23 @@ private final Metrics metrics; priv

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1127043244 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -226,11 +246,20 @@ public void commitAsync(OffsetCommitCallbac

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1125607022 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -226,11 +246,20 @@ public void commitAsync(OffsetCommitCallbac

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1125607022 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java: ## @@ -226,11 +246,20 @@ public void commitAsync(OffsetCommitCallbac

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1125606614 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -993,7 +993,7 @@ class PlaintextConsumerTest extends BaseConsumerTest { // subs

[GitHub] [kafka] philipnee commented on a diff in pull request #13303: KAFKA-14761 Adding integration test for the prototype consumer

philipnee commented on code in PR #13303: URL: https://github.com/apache/kafka/pull/13303#discussion_r1125606496 ## core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala: ## @@ -97,7 +97,7 @@ abstract class AbstractConsumerTest extends BaseRequestTest { }