[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1197985175 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -600,6 +602,30 @@ public void testCoordinatorNotAvailable() {

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1196816858 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -668,6 +695,7 @@ public void onFailure(RuntimeException e, R

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1191665112 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1191400253 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -186,6 +187,7 @@ public ConsumerCoordinator(GroupRebalanceConfig

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1191400253 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -186,6 +187,7 @@ public ConsumerCoordinator(GroupRebalanceConfig

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1191400253 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -186,6 +187,7 @@ public ConsumerCoordinator(GroupRebalanceConfig

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1191387973 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long

[GitHub] [kafka] philipnee commented on a diff in pull request #13678: KAFKA-10337: await async commits in commitSync even if no offsets given

philipnee commented on code in PR #13678: URL: https://github.com/apache/kafka/pull/13678#discussion_r1190097766 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -1223,6 +1233,26 @@ public void maybeAutoCommitOffsetsAsync(long