[GitHub] [kafka] philipnee commented on a diff in pull request #14123: MINOR: Fix committed API in the PrototypeAsyncConsumer timeout

2023-08-01 Thread via GitHub
philipnee commented on code in PR #14123: URL: https://github.com/apache/kafka/pull/14123#discussion_r1281412776 ## core/src/test/scala/integration/kafka/api/BaseAsyncConsumerTest.scala: ## @@ -35,8 +39,12 @@ class BaseAsyncConsumerTest extends AbstractConsumerTest {

[GitHub] [kafka] philipnee commented on a diff in pull request #14123: MINOR: Fix committed API in the PrototypeAsyncConsumer timeout

2023-08-01 Thread via GitHub
philipnee commented on code in PR #14123: URL: https://github.com/apache/kafka/pull/14123#discussion_r1281407606 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -150,15 +151,33 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #14123: MINOR: Fix committed API in the PrototypeAsyncConsumer timeout

2023-07-31 Thread via GitHub
philipnee commented on code in PR #14123: URL: https://github.com/apache/kafka/pull/14123#discussion_r1279890789 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -153,12 +154,32 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #14123: MINOR: Fix committed API in the PrototypeAsyncConsumer timeout

2023-07-28 Thread via GitHub
philipnee commented on code in PR #14123: URL: https://github.com/apache/kafka/pull/14123#discussion_r1277840446 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumerTest.java: ## @@ -153,12 +153,14 @@ public void

[GitHub] [kafka] philipnee commented on a diff in pull request #14123: MINOR: Fix committed API in the PrototypeAsyncConsumer timeout

2023-07-28 Thread via GitHub
philipnee commented on code in PR #14123: URL: https://github.com/apache/kafka/pull/14123#discussion_r1277835494 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/OffsetFetchApplicationEvent.java: ## @@ -19,25 +19,33 @@ import