[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1329455102 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1329215296 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorRequestManager.java: ## @@ -38,8 +38,8 @@ * Whether there is an existing coordinator

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-18 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1329213351 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -298,8 +289,8 @@ private void onFailure(final long currentTimeMs

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-17 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1328231607 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -298,8 +289,8 @@ private void onFailure(final long currentTimeMs

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327781850 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327735512 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327733352 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1326800659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1326800659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327515651 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitApplicationEvent.java: ## @@ -19,22 +19,23 @@ import org.apache.kafka.clients.consu

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-15 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1327470102 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -141,35 +142,57 @@ private Optional send(final long curr

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-14 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1326800659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325364414 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325355774 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325353270 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -203,16 +204,17 @@ public static class UnsentRequest {

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325352296 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -381,41 +377,41 @@ public String toString() { } /**

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325349813 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -106,6 +104,7 @@ public NetworkClientDelegate.PollResult poll(fi

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325349677 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitApplicationEvent.java: ## @@ -19,22 +19,23 @@ import org.apache.kafka.clients.consu

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325345190 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325342579 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325341358 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] philipnee commented on a diff in pull request #14386: KAFKA-14960: TopicMetadata request manager

2023-09-13 Thread via GitHub
philipnee commented on code in PR #14386: URL: https://github.com/apache/kafka/pull/14386#discussion_r1325175686 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -381,41 +377,41 @@ public String toString() { } /**