[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1273004953 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,20 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1273003055 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SubscribedTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272999133 ## checkstyle/suppressions.xml: ## @@ -321,6 +321,8 @@ +

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272998731 ## checkstyle/import-control.xml: ## @@ -48,6 +48,7 @@ + Review Comment: yep correct we don't need it now that we don't have any classes in it

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272573195 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5402,6 +5412,14 @@ private Map> fromTopicPartitions(

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272561659 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,20 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272561274 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -40,23 +45,31 @@ public class TopicMetadata { */

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272558721 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,20 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272557652 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -244,16 +244,21 @@ public TargetAssignmentResult

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272551436 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1272550567 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271665613 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271047554 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -244,16 +245,18 @@ public TargetAssignmentResult

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271047554 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -244,16 +245,18 @@ public TargetAssignmentResult

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271043473 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,27 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271036247 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -40,23 +44,31 @@ public class TopicMetadata { */

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270484492 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,27 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270007353 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TopicMetadata.java: ## @@ -40,23 +44,31 @@ public class TopicMetadata { */

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1270002911 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -434,22 +437,36 @@ public void setSubscriptionMetadata(

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269957881 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java: ## @@ -87,7 +87,7 @@ private Map> membersPerTopic(final

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269953544 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269952375 ## group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json: ## @@ -29,7 +29,27 @@ { "name": "TopicName", "versions":

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269947944 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionMetadata.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269946491 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/PartitionAssignor.java: ## @@ -36,8 +36,9 @@ public interface PartitionAssignor {

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269933992 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java: ## @@ -52,33 +42,22 @@ public Map members() { return

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269930044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java: ## @@ -16,44 +16,83 @@ */ package

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269930044 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicMetadata.java: ## @@ -16,44 +16,83 @@ */ package

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269927386 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269846580 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269837065 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1269665264 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentSpec.java: ## @@ -52,33 +42,22 @@ public Map members() { return