[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-10 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r629269557 ## File path: build.gradle ## @@ -1345,6 +1349,62 @@ project(':raft') { } } +project(':server-common') { + archivesBaseName = "kafka-server-common"

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628356562 ## File path: build.gradle ## @@ -1345,6 +1349,62 @@ project(':raft') { } } +project(':server-common') { + archivesBaseName = "kafka-server-common"

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628139399 ## File path: build.gradle ## @@ -1345,6 +1349,62 @@ project(':raft') { } } +project(':server-common') { + archivesBaseName = "kafka-server-common"

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628139847 ## File path: build.gradle ## @@ -1345,6 +1349,62 @@ project(':raft') { } } +project(':server-common') { + archivesBaseName = "kafka-server-common"

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628151162 ## File path: build.gradle ## @@ -1345,6 +1349,62 @@ project(':raft') { } } +project(':server-common') { + archivesBaseName = "kafka-server-common"

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628139847 ## File path: build.gradle ## @@ -1345,6 +1349,62 @@ project(':raft') { } } +project(':server-common') { + archivesBaseName = "kafka-server-common"

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628139621 ## File path: build.gradle ## @@ -1070,6 +1071,7 @@ project(':metadata') { archivesBaseName = "kafka-metadata" dependencies { +implementation

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628139399 ## File path: build.gradle ## @@ -1345,6 +1349,62 @@ project(':raft') { } } +project(':server-common') { + archivesBaseName = "kafka-server-common"

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628139004 ## File path: build.gradle ## @@ -1267,11 +1269,13 @@ project(':raft') { archivesBaseName = "kafka-raft" dependencies { +implementation projec

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628138833 ## File path: build.gradle ## @@ -779,6 +779,7 @@ project(':core') { api project(':clients') api libs.scalaLibrary +implementation project

[GitHub] [kafka] satishd commented on a change in pull request #10638: KAFKA-12758 Added `server-common` module to have server side common classes.

2021-05-07 Thread GitBox
satishd commented on a change in pull request #10638: URL: https://github.com/apache/kafka/pull/10638#discussion_r628138696 ## File path: build.gradle ## @@ -1585,6 +1644,7 @@ project(':shell') { implementation libs.jacksonJDK8Datatypes implementation libs.jline