[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-04 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644562533 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -151,7 +148,7 @@ class ReassignPartitionsIntegrat

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-03 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644803207 ## File path: docs/upgrade.html ## @@ -43,7 +43,8 @@ Notable changes in 3 AclBindingFilter. The Admin.electedPreferredLeaders() meth

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-03 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644564429 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegr

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-03 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644564429 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegr

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-03 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644564429 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -128,11 +126,10 @@ class ReassignPartitionsIntegr

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-06-03 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r644562533 ## File path: core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala ## @@ -151,7 +148,7 @@ class ReassignPartitionsIntegrat

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-05-20 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r635846586 ## File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala ## @@ -230,15 +214,9 @@ class ReassignPartitionsCommandArgsTes

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-04-07 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r608491940 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -194,33 +192,18 @@ object ReassignPartitionsCommand extends Logging {

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-04-07 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r608470296 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -1695,14 +1367,12 @@ object ReassignPartitionsCommand extends Logging

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-04-06 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r607879162 ## File path: core/src/test/scala/unit/kafka/admin/ReassignPartitionsCommandArgsTest.scala ## @@ -230,15 +214,11 @@ class ReassignPartitionsCommandArgsTe

[GitHub] [kafka] showuon commented on a change in pull request #10471: KAFKA-12597: remove deprecated zookeeper option in ReassignPartitionsCommand

2021-04-03 Thread GitBox
showuon commented on a change in pull request #10471: URL: https://github.com/apache/kafka/pull/10471#discussion_r606757807 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -1775,29 +1429,26 @@ object ReassignPartitionsCommand extends Logging