[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

2021-12-17 Thread GitBox
showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r771181554 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -705,13 +705,13 @@ protected void onJoinPr

[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

2021-12-17 Thread GitBox
showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r771181062 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -755,18 +755,17 @@ protected void onJoinPr

[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

2021-11-18 Thread GitBox
showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r752901904 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -443,7 +443,9 @@ boolean joinGroupIfNeeded

[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

2021-11-18 Thread GitBox
showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r752900442 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -746,8 +748,8 @@ public void handle(SyncGr

[GitHub] [kafka] showuon commented on a change in pull request #11451: KAFKA-13419: Only reset generation ID when ILLEGAL_GENERATION error

2021-11-17 Thread GitBox
showuon commented on a change in pull request #11451: URL: https://github.com/apache/kafka/pull/11451#discussion_r751200340 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -755,18 +755,17 @@ protected void onJoinPr