[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777398999 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -191,6 +192,21 @@ private final Collection

[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777398361 ## File path: clients/src/main/java/org/apache/kafka/common/utils/ExponentialBackoff.java ## @@ -32,7 +32,16 @@ private final double expMax;

[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777395790 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -192,14 +214,39 @@ * @return

[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777395274 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -102,11 +119,16 @@ public static final String

[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777394827 ## File path: clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java ## @@ -70,17 +70,34 @@ public static final String

[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777394154 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -536,7 +535,12 @@ private void clearAddresses() {

[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777393726 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -357,8 +357,7 @@ private void

[GitHub] [kafka] showuon commented on a change in pull request #11627: KAFKA-13565: add consumer exponential backoff for KIP-580

2022-01-03 Thread GitBox
showuon commented on a change in pull request #11627: URL: https://github.com/apache/kafka/pull/11627#discussion_r777393490 ## File path: clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java ## @@ -372,7 +371,7 @@ private void