showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r925591743
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -307,6 +309,27 @@ class LogManager(logDirs: Seq[File],
log
}
+ // factory class for naming the log re
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921131155
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921173647
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -363,28 +390,32 @@ class LogManager(logDirs: Seq[File],
val logsToLoad =
Option(dir.listFiles).getOr
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921173647
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -363,28 +390,32 @@ class LogManager(logDirs: Seq[File],
val logsToLoad =
Option(dir.listFiles).getOr
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921168895
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -307,6 +309,27 @@ class LogManager(logDirs: Seq[File],
log
}
+ // factory class for naming the log re
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921159244
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921159244
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921131155
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921127854
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921127366
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r921125134
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -366,25 +392,31 @@ class LogManager(logDirs: Seq[File],
val numLogsLoaded = new AtomicInteger(0)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r920088305
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -317,6 +338,11 @@ class LogManager(logDirs: Seq[File],
val offlineDirs = mutable.Set.empty[(String, IOExcep
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r920087197
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -366,25 +392,31 @@ class LogManager(logDirs: Seq[File],
val numLogsLoaded = new AtomicInteger(0)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r920084388
##
core/src/main/scala/kafka/log/LogLoader.scala:
##
@@ -424,8 +433,13 @@ class LogLoader(
// we had an invalid message, delete all remaining log
w
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r920083300
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -90,6 +90,10 @@ class LogManager(logDirs: Seq[File],
private val _liveLogDirs: ConcurrentLinkedQueue[File] =
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r920082431
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -366,25 +392,30 @@ class LogManager(logDirs: Seq[File],
val numLogsLoaded = new AtomicInteger(0)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r920044770
##
core/src/main/scala/kafka/log/LogLoader.scala:
##
@@ -424,9 +432,11 @@ class LogLoader(
// we had an invalid message, delete all remaining log
w
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917648253
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -410,12 +437,34 @@ class LogManager(logDirs: Seq[File],
error(s"There was an error in one of the thread
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917646894
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -410,12 +437,34 @@ class LogManager(logDirs: Seq[File],
error(s"There was an error in one of the thread
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917646481
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -638,6 +641,221 @@ class LogManagerTest {
assertTrue(logManager.partitionsInitializing.isEmpty)
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r917645850
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -410,12 +442,34 @@ class LogManager(logDirs: Seq[File],
error(s"There was an error in one of the thread
showuon commented on code in PR #12347:
URL: https://github.com/apache/kafka/pull/12347#discussion_r912490324
##
core/src/main/scala/kafka/log/LogManager.scala:
##
@@ -282,7 +285,8 @@ class LogManager(logDirs: Seq[File],
logDirFailureChannel = logDirFailureChannel,
22 matches
Mail list logo
