[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1282907004 ## core/src/test/scala/integration/kafka/api/MetricsTest.scala: ## @@ -54,6 +57,12 @@ class MetricsTest extends IntegrationTestHarness with SaslSetup {

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1282792658 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1282791709 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1281679405 ## storage/api/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteStorageMetrics.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1281346254 ## build.gradle: ## @@ -1634,6 +1634,8 @@ project(':storage:api') { dependencies { implementation project(':clients') +implementation

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1281346254 ## build.gradle: ## @@ -1634,6 +1634,8 @@ project(':storage:api') { dependencies { implementation project(':clients') +implementation

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1281344968 ## core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280543902 ## core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280542689 ## core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280542403 ## core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java: ## @@ -179,6 +180,7 @@ public ReplicaManager build() { if (metadataCache == null)

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280529448 ## core/src/main/java/kafka/log/remote/RemoteStorageMetrics.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280348532 ## core/src/test/scala/kafka/server/KafkaRequestHandlerTest.scala: ## @@ -77,4 +79,28 @@ class KafkaRequestHandlerTest { assertEquals(Some(startTime + 200),

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280347748 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -439,12 +441,14 @@ class BrokerTopicStats extends Logging {

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1280347374 ## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ## @@ -227,7 +227,7 @@ class KafkaRequestHandlerPool(val brokerId: Int, } } -class

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1279034999 ## core/src/main/java/kafka/server/builders/ReplicaManagerBuilder.java: ## @@ -179,6 +179,7 @@ public ReplicaManager build() { if (metadataCache == null)

[GitHub] [kafka] showuon commented on a diff in pull request #14133: KAFKA-15189: only init remote topic metrics when enabled

showuon commented on code in PR #14133: URL: https://github.com/apache/kafka/pull/14133#discussion_r1279033437 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -127,7 +127,7 @@ public class RemoteLogManagerTest { RemoteStorageManager