[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882171897 @ijuma , thanks for help update the comment and messages. :) Failed tests are unrelated: ``` Build / ARM / org.apache.kafka.clients.ClientUtilsTest.testResolveDnsLook

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-882023615 @rondagostino , I also checked the system test that used `Kafka-Configs.sh`, this PR should not failed the system tests because we only force to use zk connection when updating

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-878703335 @rondagostino , thanks for the comments. Actually, I've already added 2 test cases for that: `shouldNotAllowDescribeBrokerWhileBrokerUpUsingZookeeper` -> to test `describe`

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-877736694 @rondagostino , thanks for comments and many good catch! I've updated the PR. > The PR as currently written restricts describing configs via --zookeeper to user and brok

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-877717089 @ijuma , I've uploaded the PR. Please take a look again. Thanks. Failed tests are unrelated. ``` Build / JDK 11 and Scala 2.13 / kafka.api.ConsumerBounceTest

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-872830334 @rondagostino, thanks for the comments. I've removed the constraint for the `zk-tls-config-file`. Also, I added some constraint to only allow `user` type update SCRAM related co

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-871984330 @ijuma , I've updated the PR: 1. remove the support to update quota related broker configs using ZooKeeper. 2. require `zk-tls-config-file` option when `zookeeper` is provid

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-871132339 @ijuma , I've updated the PR. Please take a look again. Thank you. Failed tests are unrelated. ``` Build / JDK 16 and Scala 2.13 / kafka.server.RaftClusterTest.t

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-860173898 @ijuma , please help review. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-853823700 @ijuma , please help review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] showuon commented on pull request #10811: KAFKA-12598: remove zookeeper support on configCommand except security config

showuon commented on pull request #10811: URL: https://github.com/apache/kafka/pull/10811#issuecomment-853823700 @ijuma , please help review this PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo