[GitHub] [kafka] tanay27 commented on a diff in pull request #14035: KAFKA-15199: Remove Leading and Trailing Spaces

2023-07-18 Thread via GitHub
tanay27 commented on code in PR #14035: URL: https://github.com/apache/kafka/pull/14035#discussion_r1267071244 ## release.py: ## @@ -692,7 +700,7 @@ def select_gpg_key(): fail("Ok, giving up") if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag): fail("Ok, giving

[GitHub] [kafka] tanay27 commented on a diff in pull request #14035: KAFKA-15199: Remove Leading and Trailing Spaces

2023-07-18 Thread via GitHub
tanay27 commented on code in PR #14035: URL: https://github.com/apache/kafka/pull/14035#discussion_r1266542795 ## release.py: ## @@ -692,7 +700,7 @@ def select_gpg_key(): fail("Ok, giving up") if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag): fail("Ok, giving

[GitHub] [kafka] tanay27 commented on a diff in pull request #14035: KAFKA-15199: Remove Leading and Trailing Spaces

2023-07-18 Thread via GitHub
tanay27 commented on code in PR #14035: URL: https://github.com/apache/kafka/pull/14035#discussion_r1266544074 ## release.py: ## @@ -310,17 +310,25 @@ def validate_release_num(version): fail("The specified version is not a valid release version number")

[GitHub] [kafka] tanay27 commented on a diff in pull request #14035: KAFKA-15199: Remove Leading and Trailing Spaces

2023-07-18 Thread via GitHub
tanay27 commented on code in PR #14035: URL: https://github.com/apache/kafka/pull/14035#discussion_r1266542795 ## release.py: ## @@ -692,7 +700,7 @@ def select_gpg_key(): fail("Ok, giving up") if not user_ok("Ok to push RC tag %s (y/n)?: " % rc_tag): fail("Ok, giving