[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1222556934 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -609,14 +686,15 @@ public synchronized void handleCompletedBatch(P

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1217640626 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -609,14 +686,15 @@ public synchronized void handleCompletedBatch(P

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1205410637 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -609,14 +686,15 @@ public synchronized void handleCompletedBatch(P

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1204028973 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -626,12 +704,14 @@ public synchronized void maybeTransitionToError

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1185797643 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -424,6 +477,11 @@ ProducerIdAndEpoch producerIdAndEpoch() { }

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1174902758 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +968,31 @@ private void transitionTo(State target) { }

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1173405147 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +968,31 @@ private void transitionTo(State target) { }

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1170149228 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -266,7 +266,7 @@ public synchronized TransactionalRequestResult beg

[GitHub] [kafka] urbandan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

urbandan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1170141463 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +968,31 @@ private void transitionTo(State target) { }