[GitHub] [kafka] vamossagar12 commented on pull request #14000: [MINOR] Fixing comment with IncrementalCooperativeAssignor#handleLostAssignments

2023-07-25 Thread via GitHub
vamossagar12 commented on PR #14000: URL: https://github.com/apache/kafka/pull/14000#issuecomment-1649939574 hey Greg, let me know what you think about my above comment specially updating the comment in question to > There are no lost assignments and there have been no revoking

[GitHub] [kafka] vamossagar12 commented on pull request #14000: [MINOR] Fixing comment with IncrementalCooperativeAssignor#handleLostAssignments

2023-07-19 Thread via GitHub
vamossagar12 commented on PR #14000: URL: https://github.com/apache/kafka/pull/14000#issuecomment-1642481356 Thanks @gharris1727 . hmm the meaning of the variable and it's usage in the comment is slightly off in this case. `revokedInPrevious` being true doesn't just signify successive

[GitHub] [kafka] vamossagar12 commented on pull request #14000: [MINOR] Fixing comment with IncrementalCooperativeAssignor#handleLostAssignments

2023-07-14 Thread via GitHub
vamossagar12 commented on PR #14000: URL: https://github.com/apache/kafka/pull/14000#issuecomment-1635636681 Hey Chris, I tagged you for this minor PR since you have context around these changes. -- This is an automated message from the Apache Git Service. To respond to the message,