[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

2023-04-19 Thread via GitHub
vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919730 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyVersionedJoinIntegrationTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

2023-04-19 Thread via GitHub
vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919367 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -249,62 +272,62 @@ public void doJoinFromLeftThenDel

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

2023-04-19 Thread via GitHub
vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1171919015 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyJoinIntegrationTest.java: ## @@ -140,9 +163,9 @@ public void doJoinFromLeftThenDelet

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

2023-04-06 Thread via GitHub
vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1160073388 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyVersionedJoinIntegrationTest.java: ## @@ -0,0 +1,301 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13522: KAFKA-14834: [5/N] Drop out-of-order records from FK join with versioned tables

2023-04-06 Thread via GitHub
vcrfxia commented on code in PR #13522: URL: https://github.com/apache/kafka/pull/13522#discussion_r1160070653 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/ForeignJoinSubscriptionSendProcessorSupplier.java: ## @@ -217,5 +207,26 @@ public voi