[GitHub] [kafka] vvcephei commented on pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-24 Thread GitBox
vvcephei commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-663746926 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-24 Thread GitBox
vvcephei commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-663631102 Hey @mjsax , Since Streams accounted for almost all of the `System.exit` calls, and since `Exit.exit` is available almost everywhere in AK, I'm proposing to add a checksty

[GitHub] [kafka] vvcephei commented on pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-24 Thread GitBox
vvcephei commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-663599523 Hey @mjsax , I double-checked, and it does seem to be the right fix. I confirmed that no matter whether you run the test with IDEA or gradle, there's nothing to automatica

[GitHub] [kafka] vvcephei commented on pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-23 Thread GitBox
vvcephei commented on pull request #9067: URL: https://github.com/apache/kafka/pull/9067#issuecomment-663223325 Hey @mjsax , can you review this? It's weird that the error is reported from `unitTest`, but the only call path to the `Exit.exit()` method is though this integration test.