[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631339580 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631158775 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void stringSerdeShouldSupp

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631158775 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void stringSerdeShouldSupp

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631158775 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void stringSerdeShouldSupp

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-12 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r631151867 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-11 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r630550102 ## File path: clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java ## @@ -106,6 +110,190 @@ public void stringSerdeShouldSupp

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-11 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r630542548 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -125,6 +126,27 @@ public UUIDSerde() { } } +

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-11 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r630542548 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -125,6 +126,27 @@ public UUIDSerde() { } } +

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-11 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r630539763 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-11 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r630539285 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-05-11 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r630523305 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-27 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r621475071 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620802248 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620457633 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620449322 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620457633 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-26 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r620449322 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-22 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r618910174 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615075871 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -128,13 +128,27 @@ public UUIDSerde() { static public fi

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615075349 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -128,13 +128,27 @@ public UUIDSerde() { static public fi

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615021158 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615020981 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615010709 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615010709 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615008995 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615005374 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r615005374 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r614954404 ## File path: checkstyle/import-control.xml ## @@ -179,6 +179,7 @@ + Review comment: Otherwise the build will fail with: ```

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2021-04-16 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r614950753 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-14 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453894509 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453894647 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java ## @@ -128,13 +128,27 @@ public UUIDSerde() { static public fi

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453894509 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -77,21 +87,39 @@ public void configure(Map configs, boo

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453893460 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListSerializer.java ## @@ -46,9 +51,14 @@ public ListSerializer() {} public

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453892850 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -131,20 +132,53 @@ private void configureInnerSerde(M

[GitHub] [kafka] yeralin commented on a change in pull request #6592: KAFKA-8326: Introduce List Serde

2020-07-13 Thread GitBox
yeralin commented on a change in pull request #6592: URL: https://github.com/apache/kafka/pull/6592#discussion_r453892518 ## File path: clients/src/main/java/org/apache/kafka/common/serialization/ListDeserializer.java ## @@ -131,20 +132,53 @@ private void configureInnerSerde(M