[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r1038293918 ## core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala: ## @@ -488,6 +488,31 @@ class ConsoleConsumerTest { assertTrue(formatter.keyDeserializer.get.asI

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951187834 ## core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala: ## @@ -488,6 +488,31 @@ class ConsoleConsumerTest { assertTrue(formatter.keyDeserializer.get.asIn

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951166345 ## core/src/main/scala/kafka/tools/ConsoleConsumer.scala: ## @@ -307,7 +311,11 @@ object ConsoleConsumer extends Logging { val partitionArg = if (options.has(partiti

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951165709 ## core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala: ## @@ -140,6 +141,29 @@ class ConsoleProducerTest { assert(reader.parseKey) } + @Test + def

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951165346 ## core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala: ## @@ -140,6 +141,29 @@ class ConsoleProducerTest { assert(reader.parseKey) } + @Test + def

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951165980 ## core/src/test/scala/unit/kafka/tools/ConsoleProducerTest.scala: ## @@ -140,6 +141,29 @@ class ConsoleProducerTest { assert(reader.parseKey) } + @Test + def

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951140387 ## core/src/test/scala/unit/kafka/tools/ConsoleConsumerTest.scala: ## @@ -488,6 +488,31 @@ class ConsoleConsumerTest { assertTrue(formatter.keyDeserializer.get.asIn

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951135651 ## core/src/main/scala/kafka/tools/ConsoleConsumer.scala: ## @@ -307,7 +311,11 @@ object ConsoleConsumer extends Logging { val partitionArg = if (options.has(partiti

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951133696 ## core/src/main/scala/kafka/tools/ConsoleProducer.scala: ## @@ -71,7 +71,10 @@ object ConsoleProducer { } def getReaderProps(config: ProducerConfig): Properties

[GitHub] [kafka] zigarn commented on a diff in pull request #12175: KAFKA-14146: Config file option for MessageReader/MessageFormatter in ConsoleProducer/ConsoleConsumer (KIP-840)

zigarn commented on code in PR #12175: URL: https://github.com/apache/kafka/pull/12175#discussion_r951133696 ## core/src/main/scala/kafka/tools/ConsoleProducer.scala: ## @@ -71,7 +71,10 @@ object ConsoleProducer { } def getReaderProps(config: ProducerConfig): Properties