chia7712 merged PR #16172:
URL: https://github.com/apache/kafka/pull/16172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2156061341
> @gongxuanzhang could you please rebase code to include #16249
Okay, next we wait for CI
--
This is an automated message from the Apache Git Service.
To respond to the mess
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2156005444
@gongxuanzhang could you please rebase code to include #16249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2155665742
I have called QA again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
gongxuanzhang commented on code in PR #16172:
URL: https://github.com/apache/kafka/pull/16172#discussion_r1630503288
##
build.gradle:
##
@@ -853,8 +851,8 @@ subprojects {
skipProjects = [ ":jmh-benchmarks", ":trogdor" ]
skipConfigurations = [ "zinc" ]
}
-
- if(Ja
chia7712 commented on code in PR #16172:
URL: https://github.com/apache/kafka/pull/16172#discussion_r1629625646
##
build.gradle:
##
@@ -853,8 +851,8 @@ subprojects {
skipProjects = [ ":jmh-benchmarks", ":trogdor" ]
skipConfigurations = [ "zinc" ]
}
-
- if(JavaVer
gongxuanzhang closed pull request #16172: KAFKA-10787: Apply spotless to
transaction-coordinator and server-common
URL: https://github.com/apache/kafka/pull/16172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2146397207
@chia7712 complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2146344557
@gongxuanzhang please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2145206355
I agree remove support JDK8.
I will change spotless version and comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2145167748
It seems we are facing Trolley problem :(
1. we use spotless 6.13 in order to **support JDK 8**
2. the google-format version used by spotless 6.13 **has issue in JDK 21**
(https
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2144668220
@gongxuanzhang Could you please check the build error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2144174063
@chia7712 I changed it , plz take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2144167371
@gongxuanzhang Could you please update the description to share the tips of
"how to test this PR"?
--
This is an automated message from the Apache Git Service.
To respond to the messag
14 matches
Mail list logo
