C0urante merged PR #14309:
URL: https://github.com/apache/kafka/pull/14309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2098726331
Thanks @gharris1727. I've reverted the changes to `Utils.java` and verified
locally with tests. Everything else looked okay on the previous CI run, going
to merge.
--
This is an
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1592678706
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -392,6 +399,146 @@ protected Map
gharris1727 commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1591196797
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -16,6 +16,15 @@
*/
package org.apache.kafka.common.utils;
+import
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2091927044
Thanks @gharris1727, can you give this another round?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586591019
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -655,27 +811,38 @@ private static ConfigInfos
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586591574
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -655,27 +811,38 @@ private static ConfigInfos
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586591136
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -392,6 +399,146 @@ protected Map
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1586590857
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -562,8 +709,13 @@ ConfigInfos validateConnectorConfig(
gharris1727 commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1585294415
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -655,27 +811,38 @@ private static ConfigInfos
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2085912341
@gharris1727 I've resolved the merge conflicts again; can you please take a
look when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2057408474
Hi @gharris1727 sorry for the delay. I've resolved the merge conflicts; let
me know what you think if you have a moment.
--
This is an automated message from the Apache Git Service.
gharris1727 commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-1928574152
Hi @C0urante could you resolve the merge conflicts now that #14304 is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-1916012508
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-1787948593
@gharris1727 similar to https://github.com/apache/kafka/pull/14304 -
apologies for the delay, I've addressed all outstanding concerns, ready for
another round when you have time
--
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1378105490
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -380,6 +387,110 @@ protected Map
C0urante commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1378078025
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -380,6 +387,110 @@ protected Map
17 matches
Mail list logo
