cadonna commented on PR #13873:
URL: https://github.com/apache/kafka/pull/13873#issuecomment-2157945450
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
cadonna closed pull request #13873: KAFKA-14133: Migrate Consumer mock in
TaskManagerTest to Mockito
URL: https://github.com/apache/kafka/pull/13873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mimaison commented on PR #13873:
URL: https://github.com/apache/kafka/pull/13873#issuecomment-2157861358
Can this be closed now? It looks like this has been done in
https://github.com/apache/kafka/commit/a33c47ea4ddc810d66b6ed17ab74e40c5b7668fb
/
https://github.com/apache/kafka/commit/8b72
divijvaidya merged PR #15112:
URL: https://github.com/apache/kafka/pull/15112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
divijvaidya commented on PR #15112:
URL: https://github.com/apache/kafka/pull/15112#issuecomment-1884860357
The test modified in this PR is successful in CI -
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15112/5/testReport/org.apache.kafka.streams.processor.internals/TaskManage
clolov commented on code in PR #15112:
URL: https://github.com/apache/kafka/pull/15112#discussion_r1443172726
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -4904,7 +4870,8 @@ public void suspend() {
final Map> assignme
divijvaidya commented on code in PR #15112:
URL: https://github.com/apache/kafka/pull/15112#discussion_r1442911556
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -4904,7 +4870,8 @@ public void suspend() {
final Map> ass
clolov commented on code in PR #15112:
URL: https://github.com/apache/kafka/pull/15112#discussion_r1442836205
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -4809,11 +4768,14 @@ public void
shouldNotFailForTimeoutExceptionOnCom
divijvaidya commented on code in PR #15112:
URL: https://github.com/apache/kafka/pull/15112#discussion_r1442788932
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -1354,14 +1346,12 @@ public void
shouldHandleTimeoutExceptionInTr
clolov commented on code in PR #15112:
URL: https://github.com/apache/kafka/pull/15112#discussion_r1440569384
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##
@@ -197,6 +196,8 @@ public class TaskManagerTest {
@Mock(type = MockT
clolov opened a new pull request, #15112:
URL: https://github.com/apache/kafka/pull/15112
This pull request migrates the consumer mock in TaskManagerTest test by test
for easier reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
clolov commented on PR #13873:
URL: https://github.com/apache/kafka/pull/13873#issuecomment-1770389966
I will provide an update on this pull request in order to not close it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on PR #13873:
URL: https://github.com/apache/kafka/pull/13873#issuecomment-1752300357
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
13 matches
Mail list logo
