chia7712 merged PR #14716:
URL: https://github.com/apache/kafka/pull/14716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1595590794
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -411,25 +394,32 @@ public void seek(final TopicPartition partition, fina
chia7712 commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1584442796
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -411,25 +394,32 @@ public void seek(final TopicPartition partition, fi
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1577406177
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1565539750
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
cadonna commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1557865864
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
cadonna commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1557865864
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1557539618
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1557449127
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -411,25 +384,22 @@ public void seek(final TopicPartition partition, fina
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1557435857
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1958,64 +1859,58 @@ public void
shouldNotCheckpointForSuspendedRunning
cadonna commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1555453187
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2039443091
Heya @cadonna! I have rebased and hopefully addressed all of the first batch
of comments. The verifications which are missing are reported as
unnecessary/uncalled by Mockito, but if you th
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553349919
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1652,81 +1598,64 @@ public void shouldReInitializeTopologyWhenResuming(
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553347186
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -312,55 +302,40 @@ public void
shouldThrowLockExceptionIfFailedToLockSt
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553289186
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1866,9 +1810,6 @@ public void
shouldReturnOffsetsForRepartitionTopicsF
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553287165
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1798,8 +1746,6 @@ public void
shouldCloseStateManagerEvenDuringFailure
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553284545
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -514,8 +496,6 @@ public void
shouldTransitToRestoringThenRunningAfterCr
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553245804
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -365,11 +356,10 @@ public void
shouldResetOffsetsToLastCommittedForSpec
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553235267
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1568,10 +1548,8 @@ public void
shouldNotShareHeadersBetweenPunctuateIt
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553224333
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
shouldThrowLockExceptionIfFailedToLockSt
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553225208
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
shouldThrowLockExceptionIfFailedToLockSt
clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553223975
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
shouldThrowLockExceptionIfFailedToLockSt
cadonna commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1552378325
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
shouldThrowLockExceptionIfFailedToLockS
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2025540351
Okay, enjoy your time off!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
cadonna commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2024894127
@clolov That is great! Looking forward to reviewing it! I am on vacation at
the moment. Maybe I can look at it next week or the week after.
--
This is an automated message from the Apac
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-2023192543
Hello @cadonna! This ought to be one of the last PRs for the migration. I
will circle back tomorrow morning to rebase it since it has been out for a long
time
--
This is an automated me
github-actions[bot] commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-1938023875
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
clolov commented on PR #14716:
URL: https://github.com/apache/kafka/pull/14716#issuecomment-1801761375
I will circle back a bit later to provide reasoning about why some seemingly
needed things were removed.
--
This is an automated message from the Apache Git Service.
To respond to the me
clolov opened a new pull request, #14716:
URL: https://github.com/apache/kafka/pull/14716
This pull requests migrates mocks from StreamTaskTest to Mockito.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
29 matches
Mail list logo
