cadonna merged PR #14852:
URL: https://github.com/apache/kafka/pull/14852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
nicktelford commented on PR #14852:
URL: https://github.com/apache/kafka/pull/14852#issuecomment-1838948422
I've rebased against trunk so this should be good to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
nicktelford commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1413700543
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,31 +62,14 @@ public RocksDBTimestampedStore(final String n
cadonna commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1413468864
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,31 +62,14 @@ public RocksDBTimestampedStore(final String name,
nicktelford commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1413187089
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,31 +62,14 @@ public RocksDBTimestampedStore(final String n
nicktelford commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1413186918
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,31 +62,14 @@ public RocksDBTimestampedStore(final String n
ableegoldman commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1412625873
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,31 +62,14 @@ public RocksDBTimestampedStore(final String
nicktelford commented on PR #14852:
URL: https://github.com/apache/kafka/pull/14852#issuecomment-1836167995
Sorry about the compile error. It should now build.
Regarding tests: agreed. When KIP-892 lands, it adds an extra CF, but at
that point RocksDBStoreTest and RocksDBTimestampedSt
nicktelford commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1412137956
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,45 +62,27 @@ public RocksDBTimestampedStore(final String n
cadonna commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1412123554
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java:
##
@@ -64,45 +62,27 @@ public RocksDBTimestampedStore(final String name,
nicktelford commented on PR #14852:
URL: https://github.com/apache/kafka/pull/14852#issuecomment-1836136670
@cadonna
> Do we have unit tests in place that test all this logic?
We don't have any tests dedicated to this, but `RocksDBStoreTest` and
`RocksDBTimestampedStoreTest` impli
cadonna commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1412057240
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -278,18 +280,74 @@ private void addValueProvidersToMetricsRecorder() {
nicktelford commented on PR #14852:
URL: https://github.com/apache/kafka/pull/14852#issuecomment-1836027702
@mjsax @ableegoldman @lucasbru @wcarlson5 @bbejeck @vvcephei @guozhangwang
I was recommended to tag you all in these Kafka Streams PRs.
--
This is an automated message from the A
nicktelford commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1410543947
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -278,13 +280,55 @@ private void addValueProvidersToMetricsRecorder() {
nicktelford commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1410509927
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -278,13 +280,55 @@ private void addValueProvidersToMetricsRecorder() {
cadonna commented on code in PR #14852:
URL: https://github.com/apache/kafka/pull/14852#discussion_r1410391609
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java:
##
@@ -278,13 +280,55 @@ private void addValueProvidersToMetricsRecorder() {
nicktelford commented on PR #14852:
URL: https://github.com/apache/kafka/pull/14852#issuecomment-1829817068
@cadonna
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
nicktelford commented on PR #14852:
URL: https://github.com/apache/kafka/pull/14852#issuecomment-1829816811
This is part of KIP-892, and has been broken out into a separate PR to
reduce the review burden on the main KIP-892 implementation, since it can be
merged independently.
Note:
nicktelford opened a new pull request, #14852:
URL: https://github.com/apache/kafka/pull/14852
When opening RocksDB, we were checking for an error in
`RocksDBTimestampedStore` to detect if the `keyValueWithTimestamp` CF is
missing.
The `openRocksDB` method now supports any number of
19 matches
Mail list logo
