Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on PR #15176: URL: https://github.com/apache/kafka/pull/15176#issuecomment-1916310489 Thanks @jolshan. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1470117099 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -813,19 +816,19 @@ class ReplicaManager(val config: KafkaConfig, val transactionalProducerInfo =

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1470109481 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -813,19 +816,19 @@ class ReplicaManager(val config: KafkaConfig, val transactionalProducerInfo = mu

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1470109774 ## core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala: ## @@ -85,6 +85,10 @@ class GroupCoordinatorConcurrencyTest extends AbstractCo

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1470109481 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -813,19 +816,19 @@ class ReplicaManager(val config: KafkaConfig, val transactionalProducerInfo = mu

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1470098563 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -982,24 +996,21 @@ class ReplicaManager(val config: KafkaConfig, producerId: Long, producerEpo

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1470096146 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -935,8 +935,12 @@ private[group] class GroupCoordinator( producerId,

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on PR #15176: URL: https://github.com/apache/kafka/pull/15176#issuecomment-1914678256 @jolshan I reworked the PR based on https://github.com/apache/kafka/pull/15087. It is quite different from the previous one. Please take a look when you get a chance. -- This is an autom

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1456228457 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -935,8 +935,9 @@ private[group] class GroupCoordinator( producerId, p

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1454773095 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -935,8 +935,9 @@ private[group] class GroupCoordinator( producerId, pro

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1454771868 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId the produc

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1454273994 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -935,8 +935,9 @@ private[group] class GroupCoordinator( producerId, p

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1454268198 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId the prod

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

jolshan commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1454267538 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId the prod

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1453051782 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId the produc

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1453042161 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId the produc

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1453039755 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1132,36 +1123,31 @@ class ReplicaManager(val config: KafkaConfig, * @param transactionalId t

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

artemlivshits commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1451074358 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId th

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on PR #15176: URL: https://github.com/apache/kafka/pull/15176#issuecomment-1887429299 @artemlivshits @jolshan Could you please take a look at this one when you get a chance? Let me know what you think. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1448892815 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId the produc

[PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

dajac opened a new pull request, #15176: URL: https://github.com/apache/kafka/pull/15176 This patch removes the extra hop via the request thread when the new group coordinator verifies a transaction. Prior to it, the ReplicaManager would automatically re-schedule the callback to a request t