dajac merged PR #15067:
URL: https://github.com/apache/kafka/pull/15067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2277855531
@DL1231 The last build failed with compilation errors. Could you please
check? I would also advice to not rebase and force-push from now on. It will be
easier for me to follow the fixes. Ot
dajac commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2277756114
I spoke too quickly. @DL1231 There are related failed tests. For instance:
* testInvalidProps() – org.apache.kafka.coordinator.group.GroupConfigTest
Could you please check?
--
This i
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2275970814
Hi @dajac. Thanks a lot for the review. I have made the required changes in
the last commit, PTAL when you get a chance.
--
This is an automated message from the Apache Git Service.
To r
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1709619817
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1119,6 +1119,16 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
logProps
}
dajac commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1708860229
##
clients/src/main/java/org/apache/kafka/common/config/ConfigResource.java:
##
@@ -33,7 +33,12 @@ public final class ConfigResource {
* Type of resource.
*/
dajac commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2258359101
@DL1231 I am back. Thanks for the update. I will review your PR asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1696845517
##
clients/src/main/java/org/apache/kafka/common/config/ConfigResource.java:
##
@@ -33,7 +33,12 @@ public final class ConfigResource {
* Type of resource.
*/
AndrewJSchofield commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1693321580
##
clients/src/main/java/org/apache/kafka/common/config/ConfigResource.java:
##
@@ -33,7 +33,12 @@ public final class ConfigResource {
* Type of resource
pranavrth commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1692910940
##
clients/src/main/java/org/apache/kafka/common/config/ConfigResource.java:
##
@@ -33,7 +33,12 @@ public final class ConfigResource {
* Type of resource.
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2212355209
@dajac Sorry for the delay, I've updated the PR, PTAL when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667624742
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667624420
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667622511
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -13426,6 +13429,99 @@ public void
testNoConversionWhenSizeExc
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667622457
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -13426,6 +13429,99 @@ public void
testNoConversionWhenSizeExc
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667605626
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667605107
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667604362
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667582518
##
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala:
##
@@ -566,6 +574,45 @@ class DynamicConfigChangeTest extends
KafkaServerTestHarness {
}
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667601409
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667600848
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667599111
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java:
##
@@ -135,6 +138,13 @@ public CoordinatorShardBuilder withTim
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667598227
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667598061
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667597645
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -118,14 +122,26 @@ private GroupCoordinatorConfig createCon
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667597539
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667597502
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667588626
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667588486
##
core/src/main/scala/kafka/server/metadata/DynamicConfigPublisher.scala:
##
@@ -114,6 +114,18 @@ class DynamicConfigPublisher(
s"${resource.name()
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667587404
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -640,7 +640,6 @@ private void transitionTo(
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667586553
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667583406
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667583107
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667582981
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -489,6 +489,45 @@ class KafkaApisTest extends Logging {
testKraftForwarding(ApiKeys.ELECT_LEADER
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667582875
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -489,6 +489,45 @@ class KafkaApisTest extends Logging {
testKraftForwarding(ApiKeys.ELECT_LEADER
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667582518
##
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala:
##
@@ -566,6 +574,45 @@ class DynamicConfigChangeTest extends
KafkaServerTestHarness {
}
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667581915
##
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala:
##
@@ -566,6 +574,45 @@ class DynamicConfigChangeTest extends
KafkaServerTestHarness {
}
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667579599
##
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##
@@ -393,6 +398,81 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
ClusterInstan
dajac commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2210547626
I'll be away until 7/29. I will continue reviewing this PR when I come back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1661004357
##
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala:
##
@@ -69,6 +70,13 @@ class ControllerConfigurationValidator(kafkaConfig:
KafkaConfig) exten
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2200071353
@dajac I've updated the PR. Please take a look again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
AndrewJSchofield commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1644173569
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -3054,6 +3054,8 @@ class KafkaApis(val requestChannel: RequestChannel,
authHelper.authori
AndrewJSchofield commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2172549632
@DL1231 Yes, I'll give the updated code a detailed review in the next few
days. Thanks for rebasing it.
--
This is an automated message from the Apache Git Service.
To respond
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2169160642
@AndrewJSchofield I've resolved the conflict, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AndrewJSchofield commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2152841499
@DL1231 I'm interested in getting group configs working. This PR is quite
out of date, in particular because there's been a lot of refactoring of configs
in Kafka recently. Would
github-actions[bot] commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-2121659770
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-1895664514
@dajac, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-1890832758
Thanks @AndrewJSchofield for the feedback, I have addressed comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1451645779
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -265,3 +266,12 @@ class ClientMetricsConfigHandler(private val
clientMetricsManager: ClientMetrics
c
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1451645649
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -4112,11 +4112,18 @@ public void testIncrementalAlterConfigs() throws
Exceptio
AndrewJSchofield commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1450403817
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -265,3 +266,12 @@ class ClientMetricsConfigHandler(private val
clientMetricsManager: ClientMetr
DL1231 commented on PR #15067:
URL: https://github.com/apache/kafka/pull/15067#issuecomment-1884122272
@AndrewJSchofield, I've updated the PR. Please take a look again. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1446824176
##
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala:
##
@@ -113,6 +121,22 @@ class ControllerConfigurationValidator(kafkaConfig:
KafkaConfig) ext
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1446824091
##
core/src/main/scala/kafka/server/BrokerServer.scala:
##
@@ -353,7 +358,8 @@ class BrokerServer(
dynamicConfigHandlers = Map[String, ConfigHandler](
Co
DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1446823998
##
clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java:
##
@@ -223,6 +223,7 @@ public enum ConfigSource {
DYNAMIC_BROKER_CONFIG, // d
AndrewJSchofield commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1446139219
##
clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java:
##
@@ -223,6 +223,7 @@ public enum ConfigSource {
DYNAMIC_BROKER_CONFIG,
DL1231 opened a new pull request, #15067:
URL: https://github.com/apache/kafka/pull/15067
This PR add resources to store and handle consumer group config.
[jira](https://issues.apache.org/jira/browse/KAFKA-14511)
Changes include:
- Adding GRUOP to resource type
- Correspondi
57 matches
Mail list logo
