Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

satishd merged PR #15820: URL: https://github.com/apache/kafka/pull/15820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

satishd commented on PR #15820: URL: https://github.com/apache/kafka/pull/15820#issuecomment-2161862623 There are a few unrelated test failures, merging it to trunk and 3.8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

satishd commented on PR #15820: URL: https://github.com/apache/kafka/pull/15820#issuecomment-2161861876 Thanks @abhijeetk88 for addressing the review comments. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1634689117 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1633050128 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2730,6 +2742,206 @@ public void testEpochEntriesAsByteBuffer() throws Exception { }

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1632218079 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2730,6 +2742,206 @@ public void testEpochEntriesAsByteBuffer() throws Exception { }

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1632218079 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2730,6 +2742,206 @@ public void testEpochEntriesAsByteBuffer() throws Exception { }

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1632125146 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedExcepti

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on PR #15820: URL: https://github.com/apache/kafka/pull/15820#issuecomment-2156212270 @kamalcph I have addressed your comments, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on PR #15820: URL: https://github.com/apache/kafka/pull/15820#issuecomment-2151797298 Hi @showuon. I have responded to your comment [here](https://github.com/apache/kafka/pull/15820#discussion_r1625465435). Please take a look. -- This is an automated message from th

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1628876545 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedExcepti

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1628819130 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedExcepti

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on PR #15820: URL: https://github.com/apache/kafka/pull/15820#issuecomment-2151343142 @abhijeetk88 , any update to this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1625465435 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1625465435 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1625304008 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1625304008 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1625304008 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1625290704 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1625271623 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rlmFet

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1624109218 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rl

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1624108812 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedExcepti

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1624108252 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rl

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1624107462 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -239,6 +244,13 @@ private void removeMetrics() { remoteStorageReaderThreadPool.removeMe

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

satishd commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1623765428 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -239,6 +244,13 @@ private void removeMetrics() { remoteStorageReaderThreadPool.removeMetric

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622486629 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rl

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622440767 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rl

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622434675 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rl

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622418590 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rl

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622418254 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rl

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622404030 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedExcepti

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622404030 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedExcepti

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622254618 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622187413 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622187413 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622181661 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rlmFe

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622178816 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rlmFe

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622159510 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622134355 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1622091326 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() { assertEquals(1, rlmFet

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

satishd commented on PR #15820: URL: https://github.com/apache/kafka/pull/15820#issuecomment-2141069773 @abhijeetk88 Can you resolve the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1619996598 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata remoteLogSegmentM

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1619996273 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata remoteLogSegmentM

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1618199858 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata remoteLogSegmentM

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1618195673 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata remoteLogSegmentM

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1618195673 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata remoteLogSegmentM

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1618191025 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata remoteLogSegmentM

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1618190777 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -153,6 +156,8 @@ public class RemoteLogManager implements Closeable { private final Remot

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

abhijeetk88 commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1618189739 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedExcepti

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1617086269 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -237,6 +242,13 @@ private void removeMetrics() { remoteStorageReaderThreadPool.removeMetri

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1617519570 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

kamalcph commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1617105411 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -738,6 +750,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws InterruptedException

Re: [PR] KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage [kafka]

showuon commented on code in PR #15820: URL: https://github.com/apache/kafka/pull/15820#discussion_r1615786577 ## core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java: ## @@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata remoteLogSegmentMetad