dajac merged PR #14857:
URL: https://github.com/apache/kafka/pull/14857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1850707387
I looked at all the failed tests and none of them are related to this PR.
The "existing failure" are related to JBDO changes. Merging to trunk.
--
This is an automated message from the Ap
dajac commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1849536819
Merged trunk to address conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
lianetm commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1847956911
Temporarily disabled a flaky test that was recently added only for the new
consumer (`testGroupIdNotNullAndValid`).
I can make it fail locally in trunk when running it in a loop so disa
dajac commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1847270893
Thanks @lianetm. I will merge it as soon as I can.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lianetm commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1847229764
Done @dajac, my bad, I had missed some new args with the merge. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
dajac commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1846677800
@lianetm The last build failed with some compilation issue. Could you please
address them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
lianetm commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1846507735
Closing/re-opening to trigger the build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lianetm closed pull request #14857: KAFKA-15574; [2/N]: Client state machine
updates
URL: https://github.com/apache/kafka/pull/14857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
lianetm commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1836284959
All test pass locally, I will keep an eye on the build here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
lianetm commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1836283568
Done, latest changes merged @dajac, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1412217786
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNewAs
dajac commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1836265424
@lianetm There are conflicts. Could you please rebase or merge trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1412204434
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNew
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1412204434
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNew
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1412178458
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -322,16 +314,14 @@ private void onErrorResponse(final
Consumer
dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1411872217
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -322,16 +314,14 @@ private void onErrorResponse(final
ConsumerGr
dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1411824345
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNewAs
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1410941917
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNew
dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1410931685
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNewAs
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1410884656
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNew
dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1410871780
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,16 @@ private void replaceUnresolvedAssignmentWithNewAs
dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1410713838
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -223,8 +232,65 @@ public void testFencingWhenStateIsReconciling
lianetm commented on PR #14857:
URL: https://github.com/apache/kafka/pull/14857#issuecomment-1832346888
Hey @dajac , thanks for the comments, all addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1409611754
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -223,8 +232,65 @@ public void testFencingWhenStateIsReconcili
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1409556953
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -365,6 +366,11 @@ private void replaceUnresolvedAssignmentWithNew
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1409556622
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -531,7 +537,13 @@ private CompletableFuture
invokeOnPartitionsRe
lianetm commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1409555977
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -223,8 +232,65 @@ public void testFencingWhenStateIsReconcili
dajac commented on code in PR #14857:
URL: https://github.com/apache/kafka/pull/14857#discussion_r1409010440
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -223,8 +232,65 @@ public void testFencingWhenStateIsReconciling
lianetm opened a new pull request, #14857:
URL: https://github.com/apache/kafka/pull/14857
Updates for the client state machine, including:
- handling transitions to fatal and fenced while member is leaving the group.
- minor improvements addressing comments.
- support for static
30 matches
Mail list logo
