dajac merged PR #14642:
URL: https://github.com/apache/kafka/pull/14642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
dajac commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1790298798
Last build did not pass. It should not be related to this PR but to be sure
I just triggered a new one.
--
This is an automated message from the Apache Git Service.
To respond to the mess
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1379231747
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
publ
AndrewJSchofield commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1379170868
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
philipnee commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1787563665
Hi @dajac - Again, thank you for the review. Your comments are addressed as
of the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the messag
dajac commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1786893772
@philipnee Thanks for the update. I left one more comment and a suggestion
for consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1377337596
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java:
##
@@ -158,4 +163,54 @@ public void testCaseInsensitiveSecurityProtocol() {
f
dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1377336442
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java:
##
@@ -158,4 +163,54 @@ public void testCaseInsensitiveSecurityProtocol() {
f
philipnee commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1786388893
Hi @dajac - Thank you for the comments. I addressed them in the latest
commits. Would you mind reviewing the changes again?
--
This is an automated message from the Apache Git Servic
dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1376703936
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
public s
philipnee commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1783444304
@kirktrue @lucasbru @dajac - Thanks for taking time to review this PR. I've
addressed the recent comments. Let me know if there's anything uncleared.
--
This is an automated message
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374998305
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374964660
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,23 @@ public class ConsumerConfig extends AbstractConfig {
public s
dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374964423
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,23 @@ public class ConsumerConfig extends AbstractConfig {
public s
dajac commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374963674
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
lucasbru commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374443906
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,23 @@ public class ConsumerConfig extends AbstractConfig {
publi
philipnee commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1782236753
Hi @kirktrue Thanks for taking time reviewing my code. I made changes
according to your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the me
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374036176
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
publ
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374035895
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
philipnee commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1374035641
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -610,6 +628,18 @@ public class ConsumerConfig extends AbstractConfig {
kirktrue commented on code in PR #14642:
URL: https://github.com/apache/kafka/pull/14642#discussion_r1373924481
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -105,6 +105,24 @@ public class ConsumerConfig extends AbstractConfig {
publi
philipnee commented on PR #14642:
URL: https://github.com/apache/kafka/pull/14642#issuecomment-1780387305
Apparently, it is not very easy to validate if the server-side assignor is
used with the local assignor option instantiating the config. We should
validate this when starting up the cl
philipnee opened a new pull request, #14642:
URL: https://github.com/apache/kafka/pull/14642
Protocol Name | Type | Default | Description
-- | -- | -- | --
group.protocol | enum | generic | A flag which indicates if the new protocol
should be used or not. It could be: generic or co
23 matches
Mail list logo
