mjsax merged PR #15219:
URL: https://github.com/apache/kafka/pull/15219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mjsax commented on PR #15219:
URL: https://github.com/apache/kafka/pull/15219#issuecomment-1949323481
@lucasbru Updates this PR. -- When I started to work on this PR, I thought
that using `synchronized` would not work, because locking/unlocking would not
always be method-local. But you are
lucasbru commented on code in PR #15219:
URL: https://github.com/apache/kafka/pull/15219#discussion_r1492366369
##
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractDualSchemaRocksDBSegmentedBytesStore.java:
##
@@ -193,17 +194,22 @@ public void put(final Byt
mjsax commented on PR #15219:
URL: https://github.com/apache/kafka/pull/15219#issuecomment-1945045218
> Do we need to lock the implementations of
AbstractDualSchemaRocksDBSegmentedBytesStore.getWriteBatches ?
Outstanding catch! I believe yes. Updated the PR.
--
This is an automated
lucasbru commented on PR #15219:
URL: https://github.com/apache/kafka/pull/15219#issuecomment-1943367130
Do we need to lock the implementations of
`AbstractDualSchemaRocksDBSegmentedBytesStore.getWriteBatches` ?
--
This is an automated message from the Apache Git Service.
To respond to th
mjsax commented on code in PR #15219:
URL: https://github.com/apache/kafka/pull/15219#discussion_r1457939699
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -146,7 +146,7 @@ public static QueryResult handleBasicQueries(
vvcephei commented on code in PR #15219:
URL: https://github.com/apache/kafka/pull/15219#discussion_r1457894664
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -146,7 +146,7 @@ public static QueryResult handleBasicQueries(
lucasbru commented on code in PR #15219:
URL: https://github.com/apache/kafka/pull/15219#discussion_r1457110433
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -146,7 +146,7 @@ public static QueryResult handleBasicQueries(
mjsax commented on PR #15219:
URL: https://github.com/apache/kafka/pull/15219#issuecomment-1897612010
I am not 100% sure if my analysis is correct, but it's my best guess so far.
Given that the test always passed locally, I would like to re-run Jenkins on
this PR a few times (but in the end
mjsax opened a new pull request, #15219:
URL: https://github.com/apache/kafka/pull/15219
ConsistencyVectorIntegrationTest failed frequently because the returned
Position from IQv2 is not immutable while the test assumes immutability. To
return a Position with a QueryResult that does not cha
10 matches
Mail list logo
