Re: [PR] KAFKA-15795: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery [kafka]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #14745: URL: https://github.com/apache/kafka/pull/14745#issuecomment-1984982734 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-15795: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery [kafka]

2023-12-07 Thread via GitHub
hanyuzheng7 commented on PR #14745: URL: https://github.com/apache/kafka/pull/14745#issuecomment-1846532869 > @hanyuzheng7 Thanks for the KIP and implementation. Maybe align the variable names with what you introduced in the KIP (or the other way around)? `newTimeFrom/To` -> `timeFrom/To` `

Re: [PR] KAFKA-15795: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery [kafka]

2023-12-03 Thread via GitHub
aliehsaeedii commented on PR #14745: URL: https://github.com/apache/kafka/pull/14745#issuecomment-1837630278 @hanyuzheng7 Thanks for the KIP and implementation. Maybe align the variable names with what you introduced in the KIP (or the other way around)? `newTimeFrom/To` -> `timeFrom/To`

Re: [PR] KAFKA-15795: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery [kafka]

2023-11-28 Thread via GitHub
hanyuzheng7 commented on PR #14745: URL: https://github.com/apache/kafka/pull/14745#issuecomment-1831225734 @mjsax ready for code review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] KAFKA-15795: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery [kafka]

2023-11-12 Thread via GitHub
hanyuzheng7 opened a new pull request, #14745: URL: https://github.com/apache/kafka/pull/14745 KIP-997: https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++Support+fetch%28fromKey%2C+toKey%2C+from%2C+to%29+to+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery We