junrao merged PR #15190:
URL: https://github.com/apache/kafka/pull/15190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
junrao commented on PR #15190:
URL: https://github.com/apache/kafka/pull/15190#issuecomment-1900901612
Thanks for triaging the test failures, @apoorvmittal10. Merging the PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
apoorvmittal10 commented on PR #15190:
URL: https://github.com/apache/kafka/pull/15190#issuecomment-1900762271
> @apoorvmittal10 : Thanks for the updated PR. LGTM. Are the test failures
related? Are they all being tracked?
@junrao The tests failures are unrelated and below are the
apoorvmittal10 commented on PR #15190:
URL: https://github.com/apache/kafka/pull/15190#issuecomment-1899343398
> @apoorvmittal10 : Thanks for the PR. A couple of minor comments.
Thanks for reviewing @junrao. I have addressed and replied to the comment.
--
This is an automated
apoorvmittal10 commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1458055273
##
server/src/test/java/org/apache/kafka/server/metrics/ClientMetricsTestUtils.java:
##
@@ -59,6 +60,7 @@ public static RequestContext requestContext() throws
apoorvmittal10 commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r145796
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -1140,9 +1141,9 @@ private[kafka] class Processor(
junrao commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1456303419
##
core/src/main/scala/kafka/network/SocketServer.scala:
##
@@ -1140,9 +1141,9 @@ private[kafka] class Processor(
apoorvmittal10 commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1453684188
##
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##
@@ -433,7 +437,7 @@ private void handleSaslToken(byte[]
apoorvmittal10 commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1453676869
##
clients/src/main/java/org/apache/kafka/common/network/KafkaChannel.java:
##
@@ -369,6 +369,16 @@ public InetAddress socketAddress() {
return
AndrewJSchofield commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1453668720
##
clients/src/main/java/org/apache/kafka/common/network/KafkaChannel.java:
##
@@ -369,6 +369,16 @@ public InetAddress socketAddress() {
return
apoorvmittal10 commented on code in PR #15190:
URL: https://github.com/apache/kafka/pull/15190#discussion_r1451631637
##
clients/src/main/java/org/apache/kafka/common/requests/RequestContext.java:
##
@@ -37,6 +37,7 @@ public class RequestContext implements
apoorvmittal10 commented on PR #15190:
URL: https://github.com/apache/kafka/pull/15190#issuecomment-1890806724
@junrao @AndrewJSchofield Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
apoorvmittal10 opened a new pull request, #15190:
URL: https://github.com/apache/kafka/pull/15190
PR adds support to capture client socket port information in Request
Context. The port from request context is used as matching criteria in
filtering clients and shall be used by metrics
13 matches
Mail list logo
