junrao merged PR #15234:
URL: https://github.com/apache/kafka/pull/15234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
apoorvmittal10 commented on PR #15234:
URL: https://github.com/apache/kafka/pull/15234#issuecomment-1907047744
> @apoorvmittal10 : Before I merge this, could you update the description of
the PR. You listed 3 options to implement the eviction. The one you picked is
based on timing wheels,
junrao commented on PR #15234:
URL: https://github.com/apache/kafka/pull/15234#issuecomment-1907023180
@apoorvmittal10 : Before I merge this, could you update the description of
the PR. You listed 3 options to implement the eviction. The one you picked is
based on timing wheels, right?
apoorvmittal10 commented on PR #15234:
URL: https://github.com/apache/kafka/pull/15234#issuecomment-1906867428
I have added one missing jira for flaky tests, others pre-existed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
apoorvmittal10 commented on PR #15234:
URL: https://github.com/apache/kafka/pull/15234#issuecomment-1906858917
> @apoorvmittal10 : Are the 30 test failures related? Thanks.
@junrao Thanks for the review, none of them is related. I find most of them
already reported, ll check once
junrao commented on PR #15234:
URL: https://github.com/apache/kafka/pull/15234#issuecomment-1906780891
@apoorvmittal10 : Are the 30 test failures related? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1463408579
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -919,4 +922,102 @@ public void
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1462570838
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -919,4 +922,102 @@ public void
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1462570838
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -919,4 +922,102 @@ public void
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1462567353
##
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java:
##
@@ -120,4 +127,16 @@ public synchronized boolean
junrao commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1462316337
##
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java:
##
@@ -120,4 +127,16 @@ public synchronized boolean
apoorvmittal10 commented on PR #15234:
URL: https://github.com/apache/kafka/pull/15234#issuecomment-1904641341
Build passed with unrelated tests failure. I ll check if any test failure
needs to be tracked, if not already.
--
This is an automated message from the Apache Git Service.
To
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461791492
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -919,4 +922,101 @@ public void
AndrewJSchofield commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461776513
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +462,35 @@ public Map matchPattern() {
return
AndrewJSchofield commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461759789
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +462,35 @@ public Map matchPattern() {
return
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461574809
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +462,35 @@ public Map matchPattern() {
return matchPattern;
AndrewJSchofield commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461552151
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +462,35 @@ public Map matchPattern() {
return
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461065097
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +459,26 @@ public Map matchPattern() {
return matchPattern;
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461010891
##
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java:
##
@@ -38,6 +39,7 @@ public class ClientMetricsInstance {
private long
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1461010437
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -919,4 +922,101 @@ public void
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1460972479
##
server-common/src/test/java/org/apache/kafka/server/util/timer/SystemTimerReaperTest.java:
##
@@ -14,10 +14,11 @@
* See the License for the specific
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1460971499
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -253,10 +266,18 @@ private ClientMetricsInstance clientInstance(Uuid
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1460970956
##
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsInstance.java:
##
@@ -38,6 +39,7 @@ public class ClientMetricsInstance {
private long
junrao commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1460103407
##
server-common/src/test/java/org/apache/kafka/server/util/timer/SystemTimerReaperTest.java:
##
@@ -14,10 +14,11 @@
* See the License for the specific language
AndrewJSchofield commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1459379766
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +459,26 @@ public Map matchPattern() {
return
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1459376549
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +459,26 @@ public Map matchPattern() {
return matchPattern;
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1459368565
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -919,4 +922,101 @@ public void
apoorvmittal10 commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1459350997
##
server/src/test/java/org/apache/kafka/server/ClientMetricsManagerTest.java:
##
@@ -919,4 +922,101 @@ public void
AndrewJSchofield commented on code in PR #15234:
URL: https://github.com/apache/kafka/pull/15234#discussion_r1459018939
##
server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java:
##
@@ -433,4 +459,26 @@ public Map matchPattern() {
return
apoorvmittal10 opened a new pull request, #15234:
URL: https://github.com/apache/kafka/pull/15234
KIP-714 requires client instance cache in broker which should also have a
time-based eviction policy where client instances which are not actively
sending metrics should be evicted. KIP
30 matches
Mail list logo
