lucasbru merged PR #14835:
URL: https://github.com/apache/kafka/pull/14835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1411833816
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -205,6 +205,26 @@ public void wakeup() {
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1411721121
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -205,6 +205,26 @@ public void wakeup() {
kirktrue commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1411470319
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -205,6 +205,26 @@ public void wakeup() {
kirktrue commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1411470319
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -205,6 +205,26 @@ public void wakeup() {
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1411254378
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -800,6 +811,11 @@ public void resetTimer() {
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1411253921
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -205,6 +205,26 @@ public void wakeup() {
kirktrue commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1411218465
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -800,6 +811,11 @@ public void resetTimer() {
AndrewJSchofield commented on PR #14835:
URL: https://github.com/apache/kafka/pull/14835#issuecomment-1833387661
@lucasbru I agree. The change has made one or two tests flaky. I will fix
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lucasbru commented on PR #14835:
URL: https://github.com/apache/kafka/pull/14835#issuecomment-1833320341
@AndrewJSchofield looks like there are related test failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
AndrewJSchofield closed pull request #14835: KAFKA-15890: Consumer.poll with
long timeout unaware of assigned partitions
URL: https://github.com/apache/kafka/pull/14835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
AndrewJSchofield commented on PR #14835:
URL: https://github.com/apache/kafka/pull/14835#issuecomment-1831559902
One of the test failures needs addressing. I'll investigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lucasbru commented on PR #14835:
URL: https://github.com/apache/kafka/pull/14835#issuecomment-1831495002
@AndrewJSchofield
Looks like the test is failing
```
org.mockito.exceptions.misusing.WrongTypeOfReturnValue:
Long cannot be returned by poll()
poll() should
AndrewJSchofield commented on PR #14835:
URL: https://github.com/apache/kafka/pull/14835#issuecomment-1829545443
> Thanks for the PR! prod code looks good to me, I just added three minor
things that I spotted while going through the code. However, I have two
requests:
> Can we add a
lucasbru commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1407452521
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -417,4 +394,128 @@ private void
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406853731
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -417,4 +394,127 @@ private void
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406699697
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -417,4 +394,127 @@ private void
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406686948
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -181,36 +191,19 @@ public
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406683119
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -417,4 +394,127 @@ private void
kirktrue commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406656043
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -159,11 +159,19 @@ public NetworkClientDelegate.PollResult
lianetm commented on PR #14835:
URL: https://github.com/apache/kafka/pull/14835#issuecomment-1828148906
Thanks for the changes @AndrewJSchofield! LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lianetm commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406402956
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -332,6 +336,72 @@ public void
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406356534
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -417,4 +394,129 @@ private void
AndrewJSchofield commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406354482
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1074,6 +1074,7 @@ boolean reconciliationInProgress() {
lianetm commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406297866
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1074,6 +1074,7 @@ boolean reconciliationInProgress() {
lianetm commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406286116
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -417,4 +394,129 @@ private void
lianetm commented on code in PR #14835:
URL: https://github.com/apache/kafka/pull/14835#discussion_r1406257828
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -417,4 +394,129 @@ private void
AndrewJSchofield opened a new pull request, #14835:
URL: https://github.com/apache/kafka/pull/14835
In the new consumer, `Consumer.poll(Duration timeout)` blocks for the entire
duration. If the consumer is joining a group and has not yet received its
assignments, the poll begins before an
28 matches
Mail list logo
