Re: [PR] KAFKA-16001: Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2166728664 @mjsax thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KAFKA-16001: Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

mjsax commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2166718530 Thanks for the PR @brenden20! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-16001: Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

mjsax merged PR #16140: URL: https://github.com/apache/kafka/pull/16140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1637062738 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,97 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1637062738 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,97 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2163090508 @mjsax can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1632136201 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -211,178 +220,52 @@ public void testResetPositionsProcessFa

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631774198 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -148,35 +169,32 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631774020 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -148,35 +169,32 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631772919 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,97 @@ import static org.junit.jupiter.api.Asser

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631771648 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,97 @@ import static org.junit.jupiter.api.Asser

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631771779 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,97 @@ import static org.junit.jupiter.api.Asser

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

mjsax commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631768784 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -148,35 +169,32 @@ public void testStartupAndTearDown() throws

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631701125 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -211,178 +219,52 @@ public void testResetPositionsProcessFa

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631698362 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -211,178 +219,52 @@ public void testResetPositionsProcessFail

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2155534482 @lianetm I implemented your new suggestions, let me know if it looks good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631653829 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,99 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631646232 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,99 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631647886 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,99 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631646852 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,99 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631646232 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,99 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631645522 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,99 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2155384516 @lianetm implemented your suggestions on the description and testConsumerNetworkThreadPollTimeComputations(). Let me know how it looks -- This is an automated message from the Apache

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2155322585 Regarding the PR description, I would suggest to update: > Removed testEnsureMetadataUpdateOnPoll() since it was doing integration testing~~, could not get a unit test to work for t

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631549092 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -72,68 +64,98 @@ import static org.junit.jupiter.api.Asserti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631524427 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -211,178 +232,80 @@ public void testResetPositionsProcessFa

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631518633 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -211,178 +232,80 @@ public void testResetPositionsProcessFail

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2155226928 @lianetm implemented suggestions and merged with trunk for no conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631457443 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -258,155 +252,66 @@ void testPollResultTimer() { N

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2154902452 Hey @brenden20 , thanks for the update, just 2 minor comments left. Could you please get trunk latests changes and solve the conflicts? Thanks! -- This is an automated message from the

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631259791 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -258,155 +252,66 @@ void testPollResultTimer() { Net

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1631257210 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -258,155 +252,66 @@ void testPollResultTimer() { Net

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630153025 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -341,6 +309,24 @@ void testRunOnceInvokesReaper() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630086160 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -212,40 +251,15 @@ public void testResetPositionsProcessFai

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2153227747 I completed another pass @brenden20 , left some comments to consider getting rid of some instances that we couldn't still mock but seems possible. Thanks! -- This is an automated messag

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630082187 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +184,49 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630075479 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -341,6 +309,24 @@ void testRunOnceInvokesReaper() { @T

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630075479 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -341,6 +309,24 @@ void testRunOnceInvokesReaper() { @T

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630075479 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -341,6 +309,24 @@ void testRunOnceInvokesReaper() { @T

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630033370 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -212,40 +251,15 @@ public void testResetPositionsProcessFailu

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630022846 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -258,77 +272,31 @@ void testPollResultTimer() { Netw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1630020941 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +184,49 @@ public void testStartupAndTearDown() throw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1629578263 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() throw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628618091 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +79,113 @@ import static org.junit.jupiter.api.Asse

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628611058 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +79,113 @@ import static org.junit.jupiter.api.Asse

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628610328 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -341,6 +356,17 @@ void testRunOnceInvokesReaper() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628598367 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -341,6 +356,17 @@ void testRunOnceInvokesReaper() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628596559 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628596024 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628596024 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628595462 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628593481 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628593481 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628593280 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +79,113 @@ import static org.junit.jupiter.api.Asse

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628589378 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628502331 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -78,64 +81,120 @@ import static org.mockito.Mockito.doAnsw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2150972168 Hey @brenden20 , thanks for the updates! Left some minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628443660 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -353,13 +379,22 @@ void testSendUnsentRequest() { as

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628434821 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +52,105 @@ import static org.junit.jupiter.api.Assert

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628418739 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,35 +200,44 @@ public void testStartupAndTearDown() throw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628408348 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +79,113 @@ import static org.junit.jupiter.api.Assert

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628406670 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +79,113 @@ import static org.junit.jupiter.api.Assert

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628374297 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -270,30 +326,27 @@ void testPollResultTimer() { void t

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628152712 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -78,64 +81,120 @@ import static org.mockito.Mockito.doAnswer

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628152712 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -78,64 +81,120 @@ import static org.mockito.Mockito.doAnswer

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628131861 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,19 +209,19 @@ public void testStartupAndTearDown() throw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628070196 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,19 +209,19 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1628008988 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -78,64 +81,120 @@ import static org.mockito.Mockito.doAnsw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1627478606 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -292,7 +292,8 @@ private void closeInternal(final Duration time

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1627474682 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,19 +209,27 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1627471906 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -78,64 +81,120 @@ import static org.mockito.Mockito.doAnsw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1627235270 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -78,64 +81,120 @@ import static org.mockito.Mockito.doAnsw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1627218743 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -78,64 +81,120 @@ import static org.mockito.Mockito.doAnsw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1626607635 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1626606071 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2148211980 @lianetm @kirktrue @philipnee, I have implemented all suggestions except for test removals since I think if we do that, it should go on another ticket as to not bog this ticket down. Al

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1626467806 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1626465679 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -289,10 +289,11 @@ private void closeInternal(final Duration ti

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1626464002 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,19 +209,19 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625068181 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -270,30 +326,27 @@ void testPollResultTimer() { void tes

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625068181 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -270,30 +326,27 @@ void testPollResultTimer() { void tes

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on PR #16140: URL: https://github.com/apache/kafka/pull/16140#issuecomment-2146155510 Hey @brenden20, very nice improvement! Left a few comments. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625068181 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -270,30 +326,27 @@ void testPollResultTimer() { void tes

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625060556 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -270,30 +326,27 @@ void testPollResultTimer() { void tes

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625059147 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -289,10 +289,11 @@ private void closeInternal(final Duration time

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625054713 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -329,6 +382,8 @@ void testEnsureEventsAreCompleted() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625048146 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,19 +209,19 @@ public void testStartupAndTearDown() throw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625034602 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,19 +209,19 @@ public void testStartupAndTearDown() throw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

lianetm commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1625032096 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -150,19 +209,19 @@ public void testStartupAndTearDown() throw

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1624586673 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

brenden20 commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1624585963 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623649872 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -339,6 +358,15 @@ void testRunOnceInvokesReaper() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623649732 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -339,6 +358,15 @@ void testRunOnceInvokesReaper() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648674 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -231,10 +254,7 @@ public void testAssignmentChangeEvent() {

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648578 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -207,7 +230,7 @@ public void testResetPositionsProcessFailu

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648474 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623648058 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623647935 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +52,105 @@ import static org.junit.jupiter.api.Asse

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623647643 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +52,105 @@ import static org.junit.jupiter.api.Asse

Re: [PR] KAFKA-16001 Migrated ConsumerNetworkThreadTest away from ConsumerTestBuilder [kafka]

philipnee commented on code in PR #16140: URL: https://github.com/apache/kafka/pull/16140#discussion_r1623647362 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -74,68 +52,105 @@ import static org.junit.jupiter.api.Asse

  1   2   >