gharris1727 merged PR #15389:
URL: https://github.com/apache/kafka/pull/15389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apa
gharris1727 commented on PR #15389:
URL: https://github.com/apache/kafka/pull/15389#issuecomment-2021497976
Test failures appear unrelated, and the connect:runtime tests pass for me
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ahmedsobeh commented on PR #15389:
URL: https://github.com/apache/kafka/pull/15389#issuecomment-2020172004
> Hi @ahmedsobeh This is looking great now!
>
> Since we're in the area, I want to try and clean up the warnings in this
class, especially since some of them are on lines you've
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1538282799
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -115,64 +115,61 @@ public class StandaloneHerderTest {
ahmedsobeh commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1538122992
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -726,21 +683,21 @@ public void testAccessors() throws E
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535731883
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -226,59 +223,51 @@ public void testCreateConnectorAlre
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535731883
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -226,59 +223,51 @@ public void testCreateConnectorAlre
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535731883
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -226,59 +223,51 @@ public void testCreateConnectorAlre
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535727231
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -726,21 +683,21 @@ public void testAccessors() throws
ahmedsobeh commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535694321
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -726,21 +683,21 @@ public void testAccessors() throws E
ahmedsobeh commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535665054
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -773,40 +730,34 @@ public void testPutConnectorConfig()
ahmedsobeh commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535654142
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -226,59 +223,51 @@ public void testCreateConnectorAlrea
ahmedsobeh commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1535652744
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -726,21 +683,21 @@ public void testAccessors() throws E
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1523493857
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -726,21 +683,21 @@ public void testAccessors() throws
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1523479764
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -773,40 +730,34 @@ public void testPutConnectorConfig(
ahmedsobeh commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1523007035
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -773,40 +730,34 @@ public void testPutConnectorConfig()
ahmedsobeh commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1522985257
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -726,21 +683,21 @@ public void testAccessors() throws E
gharris1727 commented on code in PR #15389:
URL: https://github.com/apache/kafka/pull/15389#discussion_r1517018424
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -773,40 +730,34 @@ public void testPutConnectorConfig(
ahmedsobeh opened a new pull request, #15389:
URL: https://github.com/apache/kafka/pull/15389
- Removed the connector field.
- The class had a mix of Mock annotations and mock(Class) invocations,
cleaned up one of them
- The test doesn't stop the thread pool created inside the herder a
19 matches
Mail list logo
